openlibhums / openlibhums/janeway
Allow previewing download links
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 238
- Forks
- 97
- Avg merge
- 9d 1h
- Merged PRs (30d)
- 8
Description
User story
Before publication, when proofing an article, I may want to check if the file download links work. I may not be sure if they point to the right versions of the files. Or I may not be sure that I uploaded them properly and want to be sure before I publish the article.
Currently, I can't do that when previewing the article page, because journal.views.view_galley and journal.views.download_galley check if the article is published and return a 404 if it isn't.
Janeway version
1.7.3
Proposed solution
- Alter these views (
download_galleyandview_galleysomehow so that it considers whether the article is being proofed, and returns the appropriate file if so. - Remove these notes to proofreaders in the templates, as they will no longer be accurate:
https://github.com/openlibhums/janeway/blob/d9e6837a9e6bceff89446dd48debf2268b19d605/src/themes/OLH/templates/journal/article.html#L368-L373
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with journal.views.view_galley and journal.views.download_galley, which currently return 404 responses for unpublished articles. Then inspect the article template at src/themes/OLH/templates/journal/article.html around lines 368-373. Done means proofed articles can preview and download the appropriate files, and the outdated proofreader notes are removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, web-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100