openlibhums / openlibhums/janeway
User signatures sometimes have visible HTML tags
Open
Nobody has claimed this yet.
bug
dev-ready
olh-editorial-priority
Priority medium
Size S
- Dominant language
- Python
- Stars
- 238
- Forks
- 97
- Avg merge
- 9d 1h
- Merged PRs (30d)
- 8
Description
Problem description
When an editor sends a task email, the user signature often includes unparsed HTML tags, because it has not been marked safe in the template.
Proposed solution
- Inventory the setting values on major installations. There are some settings that have not been fixed in the DB, even though they have been fixed in the default setting text (JSON). For example: copyeditor_notify_author.
- Check the default setting values to make sure they already use
request.user.signature|safe. - Write a migration that catches all current and default values and updates them to use
request.user.signature|safe.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inventorying the current setting values and reviewing the default setting text (JSON), especially copyeditor_notify_author. Check which values contain request.user.signature without the safe filter, then implement a migration covering both current and default values and verify that signatures no longer display HTML tags.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, database
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100