openlibhums / openlibhums/janeway
Can't set relative URLs on custom nav items
Open
Nobody has claimed this yet.
bug
dev-ready
- Dominant language
- Python
- Stars
- 238
- Forks
- 97
- Avg merge
- 9d 1h
- Merged PRs (30d)
- 8
Description
Describe the bug
When creating a nav item that points to a site path, the resulting URL is broken
Janeway version
hourglass-v1.0
To Reproduce
- On your press settings, select OLH as your theme
- Create a custom nav item that points to /journals
- Visit the link on your navbar
- See resulting URL is https://journals
Expected behavior
Existing behaviour should be preserved and relative URLs should work as expected
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the OLH theme by creating a custom nav item pointing to /journals, then trace how the navbar URL is generated. Done means the link preserves the relative path and resolves to the site's /journals page rather than https://journals.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100