openlibhums / openlibhums/janeway
No warning or option to undo when deleting a submission field
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 238
- Forks
- 97
- Avg merge
- 9d 1h
- Merged PRs (30d)
- 8
Description
Describe the bug
at submit/manager/additional_fields/ you have the option to edit or delete an existing field. If you click 'delete' the field is deleted, with no warning or confirmation to proceed - this can easily be done by accident. There is also no immediate way to undo this action if it was an accident.
Janeway version
1.5.1-RC4
To Reproduce
Steps to reproduce the behaviour:
- Go to [journal]/submit/manager/addtional_fields/
- click the delete button on any of the listed fields
Expected behaviour
I would expect there to be a warning and requirement to confirm deletion at minimum.
I would like there to be an immediate way to undo the action as well, if it were done in error.
Ideally, there would be an easy way to retrieve previously deleted fields at a later date - i.e. a difference between deleting permanently and a recycling bin from which they could be retrieved for a set period of time before being permanently deleted.
Additional context
This is different to the behaviour of a very similar screen in the same section, submit/manager/licences/ where licences are displayed in the same manner as fields are in the this screen, but the delete button takes you to a new page which warns about deleting the item and you have to click another button to confirm the action.
Users familiar with the licence page would expect similar behaviour on the additional_fields one - this inconsistency is unhelpful.
- Add confirmable form when deleting
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at submit/manager/additional_fields/ and compare its delete flow with submit/manager/licences/, where deletion already requires a warning and confirmation. Add the comparable confirmable form for additional fields, then verify that clicking delete no longer removes a field without confirmation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100