openlibhums / openlibhums/janeway
Possible XSL regression for disp-formula
@mauromsl is already working on this.
Since Oct 16, 2023.
- Dominant language
- Python
- Stars
- 238
- Forks
- 97
- Avg merge
- 9d 1h
- Merged PRs (30d)
- 8
Description
Describe the bug
Andy patched the Material theme CSS in 2018 in #380 in such a way that indicates he expected each math formula to be inside an element with .disp-formula. At the time it seems our XSLT must have placed the equation inside this element:
However, the XSL now seems to place the math formulae outside .disp-formula:
This means Andy's patch stopped working and the bug reappeared in https://github.com/BirkbeckCTP/janeway/issues/3753.
Janeway version
d4999b8361e5b85ce44f891a691c2be73d497b1c
Expected behavior
The XSL perhaps should be placing the equations inside .disp-formula.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.