openlibhums / openlibhums/janeway
Document manager file upload error
Nobody has claimed this yet.
- #3847 by @StephDriver — closed without merging
- Dominant language
- Python
- Stars
- 238
- Forks
- 97
- Avg merge
- 9d 1h
- Merged PRs (30d)
- 8
Description
Describe the bug
When a user attempts to upload a file but clicks an upload button that does not correspond to the document field it causes a server error
Janeway version
1.5.0
To Reproduce
- Go to document management for any article
- Click "Upload File"
- Fill in file label
- Select a document under "New Manuscript File"
- Click the "Upload" button in the "Figure/Data File" section
Expected behavior
Probably this should cause a form error indicating there is no file to upload but also the interface could be changed so there aren't a bunch of different upload buttons.
Front-end Issues
If the issue is front-end specific please add the following details:
Desktop (please complete the following information):
- MacOS 13.2.1
- Firefox 118.0.1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in document management for an article and reproduce the listed upload sequence, selecting a document under "New Manuscript File" and clicking the "Figure/Data File" upload button. Trace the document-management upload entry point and determine whether the completed behavior should be a form error instead of a server error; confirm the issue's expected behavior after testing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100