openlibhums / openlibhums/janeway

Preprints: Authors shouldn't be able to update / upload new version of rejected preprint

Open
#3,087 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Priority medium Repositories Size L
Dominant language
Python
Stars
238
Forks
97
Avg merge
9d 1h
Merged PRs (30d)
8

Description

Describe the bug
An author is able to update a preprint that has been rejected, and moderators are able to act on those updates.

Janeway version
Janeway 1.4.x Preprints

To Reproduce
Steps to reproduce the behavior:

  1. Reject a non-published preprint.
  2. Log into the submitting author account
  3. See that submitting author can successfully update the preprint (e.g. add a new verison)
  4. As moderator/admin, go to versions awaiting moderation and open the new version of the rejected preprint
  5. Approve the new version
  6. Encounter server error
  7. View item metadata and see the new updates
  8. View the log and see no entry of the new version submission or approval

Expected behavior
Submitting author cannot make edits to a rejected preprint. They must either request that moderator/admin unreject preprint or make a new preprint submission.

Any newly submitted or approved versions would be displayed in logs

Screenshots
image

image

Server error upon accepting new version of rejected preprint:
image

Updated title displays:
image

Log (admin unrejected preprint on same date as above screenshots for demonstration purposes):
image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the rejected-preprint workflow described in the issue: reject a non-published preprint, submit a new version as its author, then try to moderate it. Trace the author update and version-approval paths. Done means rejected preprints cannot be edited or versioned, approval does not produce a server error, and valid submissions and approvals appear in the logs.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.