openlibhums / openlibhums/janeway

<label> text styled as <bold> or <italic> will not display in HTML

Open
#2,776 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug dev-ready Size S XSLT
Dominant language
Python
Stars
238
Forks
97
Avg merge
9d 1h
Merged PRs (30d)
8

Description

Describe the bug
Within the <label> tag, if any text is styled as <bold> or <italic>, that text will not display at all in the Janeway HTML. The <caption> displays fine, as does any text in the same <label> tag that isn't styled. I'm not sure if any other styling tags cause the same issue.

Janeway version
1.4.1

To Reproduce
I discovered this while proofreading the HTML galley for this article, but I simply removed the offending <bold> tags so that we could publish quickly, so that galley no longer actively shows the issue. See the screenshot below for an illustration of what I was seeing. Note the colon in the <label> for Figure 3, which does display on Janeway, since it's outside the <bold> tag.

Expected behavior
All text tagged <label> should display as expected in the caption box.

Screenshots
2022-03-02_14-31-26

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or entry point is named in the issue. Start by reproducing a Janeway HTML galley with bold or italic text inside a label, then trace the label rendering path; done means all label text appears in the caption box while captions and unstyled label text remain correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
html
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.