openlibhums / openlibhums/janeway

Remove line break between <label> and <caption> text in figure display

Open
#2,467 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug XSLT
Dominant language
Python
Stars
238
Forks
97
Avg merge
9d 1h
Merged PRs (30d)
8

Description

Describe the bug
MIJ editors have requested that we remove the line break between the text (usually "Figure #" or similar) and the text.

Janeway version
The version of Janeway under which the bug has been reproduced.
If running off of master, please, indicate the current HEAD of the Janeway installation

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://journals.publishing.umich.edu/mij/plugins/typesetting/preview_galley/article/93/galley/51/
  2. Scroll down to Figure 1 (see also screenshot below)
  3. Here's the JATS tagging for this figure:
    `
    Figure 1:

Mission statement excerpts of digital rights advocacy organizations, 2019–2020.

These excerpts were pulled from the organizations’ websites.

`

Expected behavior
Instead of a line break, I think it would make sense to just insert a single space between the text of these fields.

Screen Shot 2021-09-29 at 8 48 31 am

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the figure display at the linked preview URL and inspect the rendering entry point for JATS and content. Confirm that the rendered Figure 1 label and caption have one separating space rather than a line break, and verify the result with the relevant display checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.