Definition for unsigned DC API request isn't 100% clear
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 112
- Forks
- 38
- Avg merge
- 12d 19h
- Merged PRs (30d)
- 4
Description
VP currently says:
The Verifier MAY send all the OpenID4VP request parameters as members in the request member passed to the API.
"request member" is unhelpful. This could I think be interpreted as:
{
"requests": [
{
"protocol": "openid4vp-v1-unsigned",
"data": {
"client_metadata": {
or as:
{
"requests": [
{
"protocol": "openid4vp-v1-unsigned",
"data": {
"request": {
"client_metadata": {
I'm pretty sure the first interpretation is the intended one, and the "request member" is the old name for the "data" member. We should probably change the text to say "data" member.
(Spotted by Micha@BDR during the interop.)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the OpenID4VP specification text containing the quoted sentence about the request member and compare it with the two JSON interpretations in the issue. Update the wording to identify the data member, then verify that the unsigned DC API request structure is unambiguous.
Written by the indexing model from the issue text.
Assessment
- Domain
- api, documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100