openid / openid/OpenID4VP

Extend the transaction data hashes response structure

Open
#443 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

transaction data
Dominant language
Shell
Stars
112
Forks
38
Avg merge
12d 19h
Merged PRs (30d)
4

Description

The transaction_data_hashes_alg can be separate per transaction_data entry, but in the response it is expected that all transaction data hashes use the same transaction_data_hashes_alg.

Wouldn't it make more sense to make the transaction_data_hashes an array of objects, where each entry has a hash and a hash_alg, so that separate entries can be hashed using different algs?

This could also prevent conflicts where I ask for two transaction data hashes for the same credential id, one that only allows sha-256 and the other that only allows sha-512.

I think it could also help with #442, where the object could contain a transaction_data_index to point to the index from the request to make it easier to link between the request entry and the response entry

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the current transaction data hashes response structure described in this issue and compare it with the per-entry transaction_data requirements. Read issue #442 for the related linking concern. Done means the proposed response changes are specified consistently, including how separate algorithms and request-to-response entries are represented.

Written by the indexing model from the issue text.

Assessment

Domain
api, authentication
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.