openid / openid/AppAuth-iOS

authState as a property of AppDelegate

Open
#849 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug triage
Dominant language
Objective-C
Stars
2k
Forks
867
Avg merge
4d 48m
Merged PRs (30d)
1

Description

According to the documentation, the "containing" class should have this property added:

// property of the containing class
private var authState: OIDAuthState?

The currentAuthFlow property is supposed to be in the AppDelegate.

In order to automatically use refresh tokens before expiry, I need to wrap my Rest calls using the authState property from above. However, those classes don't have access to the login/logout view controller. Can I safely move the property to the AppDelegate as well or are there any hidden issues I am not aware of in doing so?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the documentation describing the containing class, authState, and currentAuthFlow, then inspect the AppDelegate and login/logout flow guidance. Determine whether the documented ownership and access pattern is safe for refresh-token-wrapped REST calls; done means the documentation clearly explains the supported placement and any constraints.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
authentication, mobile-dev
Issue type
Documentation
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.