openid / openid/AppAuth-iOS

Expose "AdditionalParameters" being returned by Token Endpoint in the response (OIDTokenResponse) to back to clients .

Open
#839 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement triage
Dominant language
Objective-C
Stars
2k
Forks
867
Avg merge
4d 48m
Merged PRs (30d)
1

Description

Is your feature request related to a problem you're having? Please describe.
Currently the library ignores the custom AdditionalParamters sent by Token-endpoint.

Describe the solution you'd like
OIDTokenResponse object has the field "additionalparamters" which holds the any additionalParamter being sent by the Token Endpoints, and when returning to clients OIDAuthState object is being returned which ignores the additionalParamters being sent.

Describe alternatives you've considered

Additional context
Add any other context or screenshots about the feature request here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how OIDTokenResponse is converted into or represented by OIDAuthState, focusing on where additionalparamters are currently retained or discarded. Determine the public response path back to clients and expose the additional parameters there without changing unrelated token data. Confirm that clients can read the values returned by the token endpoint.

Written by the indexing model from the issue text.

Assessment

Tech stack
objective-c
Domain
authentication, mobile-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.