Salesforce B2c Commerce IDP
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 2k
- Forks
- 867
- Avg merge
- 4d 48m
- Merged PRs (30d)
- 1
Description
Describe the bug
I am trying to use the lib react-native-app-auth for Salesforce B2c Commerce IDP integration.
After being authorised by the provider, the SFSafariViewController is not closed and returns the authorization response. Instead, it navigates to the redirect URL.
Neither application:openURL:options: nor application:continueUserActivity:restorationHandler is called, hence resumeExternalUserAgentFlowWithURL: is not invoked.
However, it works well with the external browser safari.
Screenshots
Environment
- Device: iPhone 14 Pro
- OS: iOS 16.2
Additional context
The original issue was filed against react-native-app-auth, but it is more likely the native lib issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the native SFSafariViewController flow around application:openURL:options:, application:continueUserActivity:restorationHandler, and resumeExternalUserAgentFlowWithURL:. Compare the SFSafariViewController behavior with the external Safari path described in the issue; done means the authorization response is returned and the in-app browser closes for this provider.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, objective-c
- Domain
- authentication, mobile-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100