Need a instance method to update OIDAuthState with both authorization response and token response
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 2k
- Forks
- 867
- Avg merge
- 4d 48m
- Merged PRs (30d)
- 1
Description
Is your feature request related to a problem you're having? Please describe.
In our workflow we need to update an OIDAuthState instance with both authorization and token response. Because OIDAuthState doesn't provide this API we have to update them separately and every time OIDAuthState update itself the delegate stateChangeDelegate is triggered. In order not to trigger it twice we have to unset and reset the delegate carefully.
Describe the solution you'd like
A new instance method in OIDAuthState.h
- (void)updateWithAuthorizationResponse:(OIDAuthorizationResponse *)authorizationResponse
tokenResponse:(OIDTokenResponse *)tokenResponse
error:(nullable NSError *)error
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with OIDAuthState.h and the existing separate authorization-response and token-response update paths. Add the requested combined instance method, preserving the supplied error and ensuring stateChangeDelegate is triggered once for the combined update; verify the behavior against the current update flow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- objective-c
- Domain
- api, authentication, mobile-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100