Pass UIWindow/ASWebAuthenticationPresentationContextProviding argument directly
Open
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 2k
- Forks
- 867
- Avg merge
- 4d 48m
- Merged PRs (30d)
- 1
Description
Is your feature request related to a problem? Please describe.
Accessing window from view controller is not right. This window is not always there.
Describe the solution you'd like
Just let pass this argument directly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the authentication entry point that currently accesses a window from a view controller, then trace its callers and the UIWindow/ASWebAuthenticationPresentationContextProviding usage. The work is done when the presentation-context argument is passed directly through the relevant API and the window lookup is no longer required.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, objective-c
- Domain
- authentication, mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100