authStateByPresentingAuthorizationRequest does not pass additional parameters to token request
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 2k
- Forks
- 867
- Avg merge
- 4d 48m
- Merged PRs (30d)
- 1
Description
Describe the bug
When trying to authenticate with an OIDC provider that utilizes https://datatracker.ietf.org/doc/html/rfc7523 (JSON Web Token (JWT) Profile for OAuth 2.0 Client Authentication and Authorization Grants) - it is not possible to use the convenience function authStateByPresentingAuthorizationRequest
This function calls the OIDAuthorizationResponse tokenExchangeRequest - rather than allowing to pass through Additional Parameters by allowing the use of OIDAuthorizationResponse tokenExchangeRequestWithAdditionalParameters - even where Additional Parameters are passed to OIDAuthState
This seems like a workflow that has been overlooked.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace authStateByPresentingAuthorizationRequest into OIDAuthorizationResponse tokenExchangeRequest and compare it with tokenExchangeRequestWithAdditionalParameters. Confirm that additional parameters supplied to OIDAuthState can reach the token request for this workflow, including the JWT client-authentication case described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- objective-c
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100