openid / openid/AppAuth-iOS

Different error code for 'Issued at time' error

Open
#644 0 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Objective-C
Stars
2k
Forks
867
Avg merge
4d 48m
Merged PRs (30d)
1

Description

I need to override error message "Issued at time is more than 600 seconds before or after the current time" to a more informative message to inform user about incorrect date and time on their device, so that they could fix it and be able to sign in to the app. This error has code OIDErrorCodeIDTokenFailedValidationError -15, but same generic error code is also used for other errors, so the only workaround I'm currently using to get this 'issued at time' error is by comparing error message strings.
I would suggest having distinct error code for this instead of generic OIDErrorCodeIDTokenFailedValidationError, so that the error could be properly handled.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the AppAuth-iOS SDK code that defines OIDErrorCodeIDTokenFailedValidationError and handles the “Issued at time” validation error. Check existing error-code tests or validation tests, then confirm that the issued-at-time case has a distinct code and that the existing generic cases remain unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
objective-c
Domain
authentication, mobile-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.