openid / openid/AppAuth-iOS

Logout Flow - AlertView saying SIGN IN

Open
#643 20 comments 10 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Objective-C
Stars
2k
Forks
867
Avg merge
4d 48m
Merged PRs (30d)
1

Description

Hi,
I implemented the login flow using the library and now I need to implement the log out also using the same library. I've seen the feature is under development but it's possible to implement it in the apps.
The only main problem I have is that the user is prompted with the same alert as in login and the texts says SIGN IN, which is confusing for the user. Is there any way to make this alert configurable? To show it / don't show it or to customize the text appearing.

I'm using the request as OIDEndSessionRequest and an agent using OIDExternalUserAgentIOS and then using the flow as

presentEndSessionRequest:(OIDEndSessionRequest *)request
       externalUserAgent:(id<OIDExternalUserAgent>)externalUserAgent
       callback:(OIDEndSessionCallback)callback;

I know there's a branch for logout under development but I cannot use a development version in the app.

Any tip will be appreciated!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at presentEndSessionRequest:externalUserAgent:callback: and trace the logout flow's alert presentation. Determine whether the SIGN IN alert can be configured or suppressed, then verify that logout presents appropriate configurable text or no alert as requested.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, objective-c
Domain
authentication, mobile
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.