openid / openid/AppAuth-iOS

Crashes

Open
#579 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Objective-C
Stars
2k
Forks
867
Avg merge
4d 48m
Merged PRs (30d)
1

Description

Just updated to the latest version of AppAuth and now our app is crashing.

-[OIDURLQueryComponent addParameter:value:]
OIDURLQueryComponent.m, line 116

Last Exception Backtrace

    CoreFoundation
    __exceptionPreprocess
    libobjc.A.dylib
    objc_exception_throw
    CoreFoundation
    _CFThrowFormattedException
    CoreFoundation
    -[__NSArrayM insertObject:atIndex:]
    CoreFoundation
    -[__NSArrayM insertObject:atIndex:]
    AppAuth
    -[OIDURLQueryComponent addParameter:value:] OIDURLQueryComponent.m:116
    AppAuth
    -[OIDTokenRequest URLRequest] OIDTokenRequest.m:292
    AppAuth
    +[OIDAuthorizationService performTokenRequest:originalAuthorizationResponse:callback:] OIDAuthorizationService.m:433
    AppAuth
    -[OIDAuthState performActionWithFreshTokens:additionalRefreshParameters:dispatchQueue:] OIDAuthState.m:513
    AppAuth
    -[OIDAuthState performActionWithFreshTokens:additionalRefreshParameters:] OIDAuthState.m:465
    GTMAppAuth
    -[GTMAppAuthFetcherAuthorization authorizeRequestArgs:] GTMAppAuthFetcherAuthorization.m:223
    GTMAppAuth
    -[GTMAppAuthFetcherAuthorization authorizeRequest:completionHandler:] GTMAppAuthFetcherAuthorization.m:446

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with OIDURLQueryComponent.m at line 116 and follow the token-request path through OIDTokenRequest.m:292, using the supplied backtrace as the entry point. Reproduce the crash with the affected AppAuth version and determine the triggering input; done means the cause and a verified resolution are documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, objective-c
Domain
authentication, mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.