openid / openid/AppAuth-iOS

Define modules

Open
#559 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Objective-C
Stars
2k
Forks
867
Avg merge
4d 48m
Merged PRs (30d)
1

Description

Are you filing an issue about iOS 12?
You can find preliminary support for iOS 12 in the (ios12beta branch)[https://github.com/openid/AppAuth-iOS/tree/ios12beta] and background information in (the associated pull request)[https://github.com/openid/AppAuth-iOS/pull/246]. Please review these materials before filing iOS 12 issues. Thanks.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Yes this is my case, I have embedded AppAuth in my swift pod framework, but when I try to use my lib via pod in a project I cannot even succeed in "pod install" it is always failing with error:

[!] The following Swift pods cannot yet be integrated as static libraries:

The Swift pod Auth depends upon AppAuth, which does not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set use_modular_headers! globally in your Podfile, or specify :modular_headers => true for particular dependencies.

As far as I have already tried to go on with use_modular_headers but with no success because in that case it is conflicting with
other pods, though I am using pods 1.9.3. I need a solution.

Describe the solution you'd like
A clear and concise description of what you want to happen.

I would like you to add support for modules.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported pod install failure using the Auth and AppAuth pods with static-library integration, then inspect the Podfile settings for use_modular_headers and modular_headers. Done means AppAuth provides module support so the dependency can be imported by the Swift Auth pod without the reported integration error or the conflicting global setting.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, objective-c, swift
Domain
build-system, mobile
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.