Replace NSLog with AppAuthRequestTrace
Open
Nobody has claimed this yet.
help wanted
- Dominant language
- Objective-C
- Stars
- 2k
- Forks
- 867
- Avg merge
- 4d 48m
- Merged PRs (30d)
- 1
Description
IANS did a pen test for us on our app, which uses AppAuth. They included a low risk finding in part because of some calls to NSLog. There were some in our code and I noticed there are a couple in AppAuth.
What do we think about replacing them with calls to AppAuthRequestTrace instead?
I'm happy to submit a PR for the change.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the NSLog call sites in Source/OIDIDToken.m and Source/OIDAuthState.m, then inspect nearby uses of AppAuthRequestTrace. Replace the identified calls while preserving the existing messages, and confirm both locations use AppAuthRequestTrace rather than NSLog.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- objective-c
- Domain
- authentication
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100