openid / openid/AppAuth-iOS

Using Carthage shows wrong AppAuth version (1.0) instead 1.3.0

Open
#517 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

help wanted
Dominant language
Objective-C
Stars
2k
Forks
867
Avg merge
4d 48m
Merged PRs (30d)
1

Description

Are you filing an issue about iOS 12?
No

Describe the bug
We use Carthage as dependency manager for our iOS app for including your Lib. We noticed the target AppAuth_iOS of your release version 1.3.0 still shows version 1.0.

To Reproduce
Steps to reproduce the behavior:

  1. put github "openid/AppAuth-iOS" "1.3.0" in your cartfile
  2. run carthage update --platform iOS
  3. open ($YOUR_WORKSPACE)/Carthage/Build/iOS/AppAuth.framework/Info.plist
  4. See CFBundleShortVersionString

Expected behavior
shows the current release version code

Screenshots
Bildschirmfoto 2020-03-27 um 11 37 01

Smartphone (please complete the following information):

  • Device: [All]
  • OS: [All]
  • Version [1.3.0]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Cartfile entry and reproduce the report using carthage update --platform iOS. Inspect Carthage/Build/iOS/AppAuth.framework/Info.plist, focusing on CFBundleShortVersionString; done means the generated framework reports the current 1.3.0 release version.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios
Domain
mobile-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.