iOS 13 View Controller present style options
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 2k
- Forks
- 867
- Avg merge
- 4d 48m
- Merged PRs (30d)
- 1
Description
Since iOS 13, the default presentation style of presenting a View Controller, a.k.a. modalPresentationStyle is UIModalPresentationAutomatic, in which will result in a non-fullscreen modal.
https://developer.apple.com/documentation/uikit/uimodalpresentationstyle/automatic
But in current procedure, developer can't get access to the SFSAFARIViewcontroller instance which is used to let user sign-in. It is better to give developer access to the modalPresentationStyle, to decide how the sign-inpop-up looks like.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace the current sign-in flow to the SFSafariViewController instance and review how modalPresentationStyle is handled. Define how developers would supply the presentation option and verify that the sign-in modal uses the selected style.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, objective-c
- Domain
- authentication, mobile
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100