openid / openid/AppAuth-iOS

AppAuth OIDAuthState

Open
#437 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Objective-C
Stars
2k
Forks
867
Avg merge
4d 48m
Merged PRs (30d)
1

Description

Describe the bug
I am trying to use OIDAuthState to create an GTMAppAuthFetcherAuthorization object.

The method call I use:

OIDAuthState.authState(byPresenting: request, externalUserAgent: externalUserAent,OIDCallBack:callback)

The problem is that user agent is an instance of a class I declare as such:

class ExternalUserAgent: NSObject, OIDExternalUserAgent {
    func present(_ request: OIDExternalUserAgentRequest, session: OIDExternalUserAgentSession) -> Bool {
        return true
    }
    
    func dismiss(animated: Bool, completion: @escaping () -> Void) {
        print(animated)
    }
}

With this implementation nothing happens when the OIDAuthState.authState is called.

What could be the issue with thee library as the documentation doesn't cater to this authState method which accepts an OIDUserAgent?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the OIDAuthState.authState(byPresenting:externalUserAgent:...) call and the ExternalUserAgent implementation shown in the issue. Check the AppAuth-iOS documentation and OIDExternalUserAgent flow to determine why nothing happens; done means the reported auth-state flow produces the expected user-agent behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, objective-c, swift
Domain
authentication, mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.