openid / openid/AppAuth-iOS

Including Both AppAuth and AppAuth-Core Causes Symbol Warning in App Store Upload

Open
#423 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Objective-C
Stars
2k
Forks
867
Avg merge
4d 48m
Merged PRs (30d)
1

Description

Are you filing an issue about iOS 12?
We use iOS 12 but I think it's not relevant here.

Describe the bug
Including both AppAuth and AppAuth-Core in a project via Podfile apparently causes name-collision issues in relation to symbols creation; App Store review reports issue "ITMS-90381: Too many symbol files - These symbols have no corresponding slice in any binary".

To Reproduce
Steps to reproduce the behavior:

  1. Create new project with a podfile, add
    pod 'AppAuth'
    to the main target,
    pod 'AppAuth/Core'
    to a Siri intents target
  2. Build app
  3. In Xcode, Go to Pods/Products, observe that AppAuth is listed twice, once under path AppAuth, once under AppAuth-Core.
  4. Submit app to App Store, receive warning "ITMS-90381: Too many symbol files - These symbols have no corresponding slice in any binary"

Expected behavior
I guess the Product for AppAuth-Core should have a distinct name to avoid confusing the toolchain.

Screenshots

  • none -

Desktop (please complete the following information):

  • not applicable -
    Smartphone (please complete the following information):
  • Device: any, also Simulator
  • OS: iOS 12.2
  • Browser: -
  • Version 1.0.0-rc1

Related
This issue looks related, it is supposedly fixed: https://github.com/CocoaPods/CocoaPods/issues/6819

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Podfile entries for AppAuth and AppAuth/Core and inspect the resulting Products under Pods in Xcode. Reproduce the App Store upload warning and determine whether the two products create conflicting or unmatched symbol files; done means the warning no longer occurs when both targets use these pods.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, objective-c
Domain
build-system, mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.