Configurable current time for 10 Minute token validation
Nobody has claimed this yet.
- Dominant language
- Objective-C
- Stars
- 2k
- Forks
- 867
- Avg merge
- 4d 48m
- Merged PRs (30d)
- 1
Description
Are you filing an issue about iOS 12?
No.
Is your feature request related to a problem? Please describe.
iOS users who set their device time manually to more than 10 minutes always fail on the token validation.
Describe the solution you'd like
Make the current time(timeIntervalSinceNow) configurable so that the 10-minute validation will not depend on device time only but can be set externally.
Describe alternatives you've considered
Remove the 10 minute check.
Additional context
In OIDAuthorizationService.m, current time used is hard coded to "timeIntervalSinceNow".
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in OIDAuthorizationService.m and inspect where timeIntervalSinceNow is used for the 10-minute token validation. Determine the supported way to supply an external current time, then verify that validation no longer depends solely on the device clock while preserving the existing expiry check.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- objective-c
- Domain
- authentication, mobile-dev
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100