openid / openid/AppAuth-JS

Allow request handler to stop listening for a response

Open
#89 2 comments 4 reactions 1 assignee View on GitHub

@tikurahul is already working on this.

Since Oct 29, 2018.

enhancement
Dominant language
TypeScript
Stars
1k
Forks
165
PR merge metrics
No merged PRs in 30d

Description

Expected Behavior

It would be useful if there was a method on the NodeBasedHandler to stop waiting for a response / close the server if the auth redirect flow is interrupted or cancellation request is issued

Describe the problem

If a user interrupts the auth redirect flow (closing the browser or navigating away, for example) then the authorization request never completes and the server remains waiting for a response.

Actual Behavior

There is no way to close the server

Steps to reproduce the behavior

Initiate the auth redirect, then close the browser without completing the process.

Environment
  • AppAuth-JS version: 0.3.5
  • AppAuth-JS Environment (Node, Browser (UserAgent), ...): Node

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.