depends on '@openid/appauth/built/xhr'. CommonJS or AMD dependencies can cause optimization bailouts.
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1k
- Forks
- 165
- PR merge metrics
- No merged PRs in 30d
Description
Expected Behavior
[REQUIRED] Describe expected behavior
No compilation warning in Angular >10
Describe the problem
[REQUIRED] Actual Behavior
In related issue #181 it was suggested:
The @openid/appauth import is an umbrella import for convenience. You can always just import the individual modules.
So I tried to do
import { Requestor } from '@openid/appauth/built/xhr';
but still on compilation there is warning: .../auth.module.ts depends on '@openid/appauth/built/xhr'. CommonJS or AMD dependencies can cause optimization bailouts.
[REQUIRED] Steps to reproduce the behavior
[REQUIRED] Environment
- AppAuth-JS version: ____ @openid/appauth": "^1.3.1" ____________
- AppAuth-JS Environment (Node, Browser (UserAgent), ...): ____ Angular 13.3.0 / Ionic 6.19.0___________________
- Source code snippts (inline or JSBin)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Angular 13 compilation warning with the import from @openid/appauth/built/xhr described in the issue, then inspect how AppAuth-JS exposes that module. Done means the reported import no longer produces a CommonJS or AMD optimization bailout warning during compilation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100