openfrontio / openfrontio/OpenFrontIO

Review frequency of city/port connectivity check with factory

Open
#5,248 4 comments 0 reactions 0 assignees View on GitHub
not-approved
Dominant language
TypeScript
Stars
2.7k
Forks
1.4k
Avg merge
17h 43m
Merged PRs (30d)
310

Description

Revealed in https://github.com/openfrontio/OpenFrontIO/pull/5246#issuecomment-5538844226

It is found that Cities and Ports check for factory connectivity at different frequencies. Specifically, Cities only check once at creation, but Ports check every tick.

Is this intended? Should both units check connectivity at every tick? If performance is a concern, then when it is possible for players to spam Ports (e.g. coastal area), should Ports just check connectivity only once when placed?

Contributor guide

Open the contributing guide

Research direction

Start with the city and port factory-connectivity checks described in PR 5246's issue comment, then trace when each check runs during creation and during ticks. Compare the behavior in coastal placement and repeated-port scenarios, and determine the intended frequency before documenting or implementing a consistent rule.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
game-dev, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.