openframeworks / openframeworks/projectGenerator

path internal handling is weird

Open
#6 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
CSS
Stars
90
Forks
79
Avg merge
2d 9h
Merged PRs (30d)
5

Description

there's some stuff in ofAddon (it's in the main repo, but I'm putting the issue here so it's easier to track) that seems kind of wrong to me. Paths are coming in either unix-y or windows-y, but it feels like we should make the decision to convert all paths to unix internally and only convert back when and if we need to at the project level (ie, visualStudioProject should make sure it outputs windows paths)

I'm talking specifically about stuff like this:

https://github.com/openframeworks/openFrameworks/blob/master/addons/ofxProjectGenerator/src/addons/ofAddon.cpp#L428-L432

which is making some assumptions and trying to be a bit smart about paths.... My intuition is that things like generating an OSX project on windows could break in weird ways here....

the tl;dr is - let's make sure to just use unix under the hood and convert to windows only when absolutely necessary.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting addons/ofxProjectGenerator/src/addons/ofAddon.cpp around lines 428-432 and trace how paths enter the generator and reach project-level outputs. Compare the handling of Unix and Windows paths, including the Visual Studio project case and cross-platform generation. Done means the intended internal path convention and conversion boundaries are defined and consistently applied.

Written by the indexing model from the issue text.

Assessment

Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.