openframeworks / openframeworks/projectGenerator
OF_ROOT in existing Makefile / config.make not set correctly in some cases.
Nobody has claimed this yet.
- Dominant language
- CSS
- Stars
- 90
- Forks
- 79
- Avg merge
- 2d 9h
- Merged PRs (30d)
- 5
Description
If the Makefile or config.make is in a non-standard location (e.g. where OF_ROOT != ../../..), projectGenerator will modify an existing Makefile / config.make and replace only ../../... Thus for Makefiles that are already correct (e.g. OF_ROOT=../../../../../.. the project generator will correctly determine that OF_ROOT should be ../../../../../.., but will replace the first ../../.. with ../../../../.. resulting in ../../../../../../../.. which results in a broken Makefile / config.make.
Rather than doing a find/replace on a static OF_ROOT string, projectGenerator should replace the whole line or use a regex to replace the entire existing path with its version.
Related #119
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect projectGenerator's handling of existing Makefile and config.make files, then reproduce the case where OF_ROOT differs from ../../... Verify how the current replacement changes an already-correct path. Done means an existing non-standard OF_ROOT is replaced as a complete path without corrupting either file.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100