openframeworks / openframeworks/openFrameworks
Error in ofNode::transformGL
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
There is an easy-to-correct error in ofNode::transformGL:
It should call loadMatrix with globalTransformMatrix as parameter (with a void restoreGL), or pushMatrix then multMatrix with localTransformMatrix (with a restoreGL that pops the previously pushed matrix),
NOT push then mult with global. The bug appears as soon as you have got more than one level of depth in your node tree.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ofNode::transformGL entry point and read how it uses globalTransformMatrix, localTransformMatrix, loadMatrix, pushMatrix, multMatrix, and restoreGL. Confirm the intended matrix and restore behavior from the issue, then verify that nested node trees no longer apply the global transform incorrectly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100