openframeworks / openframeworks/openFrameworks
ofOrientation, does it need to exist?
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
I suspect it can be all removed from OF Core
All usages I know can be handled by the OS, at least in iOS / macOS
removing this would simplify lots of I suppose unneded things and make it easier to have retina working for ex.
opinions? @openframeworks/core @openframeworks/2d-3d
enum ofOrientation: short{
/// \brief Represents the default screen orientation.
OF_ORIENTATION_DEFAULT = 1,
/// \brief Represents a screen rotated 180 degrees, also known as upside-down.
OF_ORIENTATION_180 = 2,
/// \brief Represents a screen rotated 90 degrees clockwise.
OF_ORIENTATION_90_LEFT = 3,
/// \brief Represents a screen rotated 90 degrees counter-clockwise.
OF_ORIENTATION_90_RIGHT = 4,
/// \brief Represents an unknown orientation.
OF_ORIENTATION_UNKNOWN = 5
};
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inventorying all usages of the ofOrientation enum in OF Core and comparing them with the OS handling on iOS and macOS. Determine the affected platforms and whether removing it would preserve existing orientation and retina behavior; done requires an agreed scope and an update plan for all affected usages.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100