openframeworks / openframeworks/openFrameworks
[actions] rpi actions passing even when failing
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
I'm not sure why github actions are "passing" even with fatal errors.
../../../libs/openFrameworks/math/ofMath.cpp
In file included from ../../../libs/openFrameworks/math/ofMath.cpp:1:
../../../libs/openFrameworks/math/ofMath.h:5:10: fatal error: glm/fwd.hpp: No such file or directory
5 | #include <glm/fwd.hpp>
| ^~~~~~~~~~~~~
compilation terminated.
make[2]: *** [makefileCommon/compile.core.mk:259:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Raspberry Pi GitHub Actions workflow and inspect how the make output from libs/openFrameworks/math/ofMath.cpp and makefileCommon/compile.core.mk is handled. Reproduce the missing glm/fwd.hpp compilation error and verify that the workflow reports failure rather than passing when the build terminates with a fatal error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, github-actions
- Domain
- build-system, ci-cd, embedded-iot
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 38/100