openframeworks / openframeworks/openFrameworks
Emscripten: Makefile should circumvent preload-file if bin/data is empty or inexistant (or otherwise catch/bypass the error on missing directory)
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
i have an app with an empty data dir that would not compile with --preload-file bin/data@data
em++: error: '..../emsdk/upstream/emscripten/tools/file_packager bin/randomexplorer.data --from-emcc --preload bin/data@data' failed (returned 1)
make[1]: *** [bin/randomexplorer.html] Error 1
make: *** [Release] Error 2
emmake: error: 'make' failed (returned 2)
not sure how to debug that or what is relevant? before the above lines the output it pretty OF standard and just some warnings, mostly macro redefinitions.
taking out the --preload-file bin/data@data makes the compile complete.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the failing emmake build with an empty or missing bin/data directory and the --preload-file bin/data@data option. Inspect the Makefile rule that generates bin/randomexplorer.html; done means the build no longer fails for an empty or missing data directory while normal preloading still works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100