openframeworks / openframeworks/openFrameworks

Makefile: INVALID_PROJECT_ADDONS seems always empty; no warnings emitted

Open
#7,281 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
10.4k
Forks
2.6k
Avg merge
1d 21h
Merged PRs (30d)
9

Description

context: https://forum.openframeworks.cc/t/addons-not-compiling-on-rpi3-and-4/41236

looking into how Make is "preparing" addons, it seems the condition to trigger the warning messages about missing addons never gets activated. the test: generate a fresh project, add ofxDummy in addons.make, and make: it goes through without warning even though there is some logic to detect valid/invalid addons:

https://github.com/openframeworks/openFrameworks/blob/b98cdfd0165b41fcb1bee5b87266bb1197271316/libs/openFrameworksCompiled/project/makefileCommon/config.project.mk#L182-L191

ofxDummy shows up in the INVALID_GLOBAL_ADDONS, but not in INVALID_PROJECT_ADDONS (which is the variable that would trigger the warning). it seems line 184 is not doing its job? and when swapping GLOBAL for PROJECT in the test at line 187 it does go through but then generates an error on the $(warning) statement: *** commands commence before first target. Stop. (I am thoroughly confused by the Makefile language). (tests done on macOS13.1 M1 commandline with github OF).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in libs/openFrameworksCompiled/project/makefileCommon/config.project.mk, especially lines 182-191, and reproduce with a fresh project containing ofxDummy in addons.make. Trace why INVALID_PROJECT_ADDONS remains empty and verify that the missing-addon warning is emitted without the commands commence before first target error.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.