openframeworks / openframeworks/openFrameworks

download_libs.sh doesn't properly download alternate versions

Open
#6,623 0 comments 1 reaction 1 assignee View on GitHub

@danoli3 is already working on this.

Since Nov 4, 2020.

Dominant language
C++
Stars
10.4k
Forks
2.6k
Avg merge
1d 21h
Merged PRs (30d)
9

Description

I believe I've found a bug in the download_libs.sh where if a VER is supplied (such as 0.10.1 or 0.11.0), the download fails. It looks like the script's logic doesn't match the URL structure of the CI filestore it downloads from (http://ci.openframeworks.cc/libs/).

An example URL is generated here:

https://github.com/openframeworks/openFrameworks/blob/28d3b492dd289895d8b2b6b67860e1dbd966eb4f/scripts/dev/download_libs.sh#L190

Which is then used here:

https://github.com/openframeworks/openFrameworks/blob/28d3b492dd289895d8b2b6b67860e1dbd966eb4f/scripts/dev/download_libs.sh#L31-L34

The logic works for a default VER of master, but doesn't work for named semantic versions (ex 0.10.1) as their URLs look like http://ci.openframeworks.cc/libs/0.10.1/openFrameworksLibs_master_linux64gcc6.tar.bz2.

A solution might catch a semver VER and direct to the correct file or add an additional variable for named branches.

I found then when attempting to implement a continuous integration build system where openFrameworks is tagged to a specific version.

Thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.