Bug / Feature - window sizing doesn't respect monitor scale on Windows

This is a Windows only issue.

If you have a setup with more than one monitor, and the content scale of the main monitor is set differently to the other monitors, additional windows that are created on the other monitors will not have the correct size.

This is particularly common with laptops, where the content scale is set to 2 or 1.75 on the integrated monitor, but additional, larger monitors will scaled at 1:1. It also seems it's only an issue on Windows, and not any of the other platforms.

This can be fixed pretty easily in ofAppGLFWWindow.cpp by adding the GLFW_SCALE_TO_MONITOR hint and setting it to true, as follows-

void ofAppGLFWWindow::setup(const ofGLFWWindowSettings & _settings) {

...
  glfwWindowHint(GLFW_STEREO, settings.stereo);
  glfwWindowHint(GLFW_VISIBLE, GL_FALSE);
#ifdef TARGET_WIN32
  glfwWindowHint(GLFW_SCALE_TO_MONITOR, GL_TRUE);
#endif
#ifndef TARGET_OSX
	glfwWindowHint(GLFW_AUX_BUFFERS, settings.doubleBuffering?1:0);
#endif
...etc
}

I've fixed it locally, I suppose the question is whether it should be an additional option in the ofGLFWWindowSettings class, and whether it should be true by default or not. The documentation from GLFW is here: https://www.glfw.org/docs/3.3/window_guide.html

Thanks in advance,

-Ed