openframeworks / openframeworks/openFrameworks
project generator vs: ADDON_CFLAGS
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
I am using the project generator from tonight's nightly build 20200215 win10 vs2017.
It does not respect vs multiple ADDON_CFLAGS unless they are passed in quotes:
vs:
# --> seems to be a bug having to write it enclosed in "..."
# next line works, taking all entries
ADDON_CFLAGS = "/bigobj -DTEST_111 -DTEST_222"
# next line += is not added
ADDON_CFLAGS += "/fromPlusEqualLineInQuotes"
# next line += is not added either
ADDON_CFLAGS += /fromPlusEqualLine
# next line works not, only takes the first entry
# ADDON_CFLAGS = /bigobj2 -DTEST_444 -DTEST_555
also having ADDON_CFLAGS in an addon before (i.e. ofxPoco using ADDON_CFLAGS = -DPOCO_STATIC) leads to the fact that none of the above are added.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the project generator on Windows using the shown vs configuration, including multiple ADDON_CFLAGS entries and an addon-defined value. Trace the generator's Visual Studio handling and addon flag merge behavior; done means unquoted multiple flags, += entries, and existing addon flags are all preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 40/100