openframeworks / openframeworks/openFrameworks

glitch in ofPolyline getResampledByCount()

Open
#6,529 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
10.4k
Forks
2.6k
Avg merge
1d 21h
Merged PRs (30d)
9

Description

OF 0.11 win10

if we resample a polyline to the same amount of vertices for getting another spacing, eg:

polyline = polyline.getResampledByCount(polyline.size()); // OF bug jumps! += 1

the result has a variable length +1, unless we put ceilf in the equation like:

assert(polyline.size() >= 2);		
polyline = polyline.getResampledBySpacing(
    ceilf(polyline.getPerimeter()) / (polyline.size() - 1)
);

this needs to be fixed in getResampledByCount()

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with ofPolyline::getResampledByCount() and the related getResampledBySpacing() behavior described in the issue. Reproduce the Windows 10 example with a target count equal to the current vertex count, then verify that the result has exactly the requested number of vertices without changing the intended spacing.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
computer-graphics
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.