openframeworks / openframeworks/openFrameworks
setupCommandLine.cmd in scripts folder does not work on VS2017
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
trying to use the script on windows, but got the report
"Cannot use msbuild with Visual Studio 2008 or earlier."
I think this is due to:
And the reason is the script only consider VS_VERSION for 140, but missing 141?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at scripts/vs/setupCommandLine.cmd, especially the version handling around line 96, and reproduce the failure with Visual Studio 2017. Verify that the script recognizes VS2017 and no longer reports that MSBuild cannot be used with Visual Studio 2008 or earlier.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100