openframeworks / openframeworks/openFrameworks

Incorrectly set top-level ofxGuiGroup headers

Open
#5,998 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
10.4k
Forks
2.6k
Avg merge
1d 21h
Merged PRs (30d)
9

Description

When I recently set an ofGui's borders to red like so:
gui.setDefaultBorderColor(ofColor(255, 0, 0));
I noticed that the border doesn't show on the left hand side of top-level ofxGuiGroup headers.

screen shot 2018-05-03 at 12 12 39 am

In the above image, the "hm1" header does not have a border visible on the left. This has to do with the header positioning rather than its borders. I've got a pull request ready to fix the issue.

I've also noticed ofxPanels don't seem to get a border at all. I'm assuming that's intended? If not I can open another issue.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The report concerns ofGui::setDefaultBorderColor and top-level ofxGuiGroup header positioning; begin by locating those entry points in the openFrameworks GUI code. Compare the current behavior with the ready pull request, and consider the work done when the left border is visible on top-level headers.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.