openframeworks / openframeworks/openFrameworks
ofPath::hasChanged and ofPath::flagShapeChanged should be public
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
Is there any reason why ofPath::hasChanged and ofPath::flagShapeChanged are private? ofPath::flagShapeChanged() could be really useful when paths are changed externally (I'm currently working around it by calling ofPath::getCommands() only so that ofPath::flagShapeChanged is called), and ofPath::hasChanged doesn't get called at all anywhere in OF... so it makes 0 sense that it is private. If it were public it would mirror the behavior of ofMesh::hasChanged, which would make the library more consistent.
c.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the ofPath declaration and implementation, then compare the visibility and use of ofMesh::hasChanged. Confirm that the requested ofPath methods can be accessed externally and that existing behavior remains intact; add or update tests if the surrounding code provides coverage for this API.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100