openframeworks / openframeworks/openFrameworks
[FEATURE REQUEST] ofxiOSVideoPlayer add load from documents method
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
The current ofxiOSVideoPlayer::load method takes a file name which is converted directly to a data path NSString * videoPath = [NSString stringWithUTF8String:ofToDataPath(name).c_str()]; inside the method.
I would like to add a method to allow loading from the iOS documents folder as well. So there would be a new method as follows:
bool load(string file);
bool loadFromDocuments(string file);
I think ideally it could even take a more generic form, taking any string as an input, but
this would probably require using Objective C code to get the path on the client's side before passing it and reconverting it to an NSString afterward, which does not seem desirable.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the ofxiOSVideoPlayer::load method and inspect how the name is converted with ofToDataPath and NSString. Add the requested loadFromDocuments(string file) entry point, then verify that it loads a video from the iOS documents folder without changing the existing load behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ios, objective-c
- Domain
- audio-video-rtc, mobile-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100