openframeworks / openframeworks/openFrameworks
ofPolyline - bool noSegmentHasZeroLength = (v1 == v1 && v2 == v2) is always true.
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
Maybe I'm missing some nuance here, but it seems that noSegmentHasZeroLength will always be true?
Here is the commit:
https://github.com/openframeworks/openFrameworks/commit/290866ec9dc16c0c0a163a8a347f8cacac457e19
@tgfrerer
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect libs/openFrameworks/graphics/ofPolyline.inl at line 1018 and compare the surrounding logic with commit 290866ec9dc16c0c0a163a8a347f8cacac457e19. Confirm whether the noSegmentHasZeroLength condition can distinguish the intended cases, then verify that the corrected behavior matches the surrounding polyline logic.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100