openframeworks / openframeworks/openFrameworks
ofxiOSVideoPlayer: Load video asynchronously in ios
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
Hi,
When I call loadAsync on iOS, as ofxiOSVideoPlayer::loadAsync is not implemented, it will call ofBaseVideoPlayer: loadAsync instead.
I'll get a waning saying ofBaseVideoPlayer: loadAsync() not implemented, loading synchronously
But ofxiOSVideoPlayer::load(string name) does try to load the video async by calling the following function:
[self.asset loadValuesAsynchronouslyForKeys:[NSArray arrayWithObject:kTracksKey] completionHandler:
So I think we are missing the implementation of:
bool ofxiOSVideoPlayer::loadAsync(string name) {
return load(name);
}
Am I missing something? If it's correct, I can make a pull request when needed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ofxiOSVideoPlayer::loadAsync and compare it with ofxiOSVideoPlayer::load(string name), which already calls loadValuesAsynchronouslyForKeys. Verify the iOS loadAsync path no longer falls back to ofBaseVideoPlayer::loadAsync or emits the synchronous-loading warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, ios
- Domain
- mobile-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100