openframeworks / openframeworks/openFrameworks
std=c++14 flag being passed to PLATFORM_CFLAGS (android)
Open
Nobody has claimed this yet.
android
makefile
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
The default android project makefile (config.default.android.mk) passes -std=c++14 to PLATFORM_CFLAGS, resulting in the following compile error for c files:
error: invalid argument '-std=c++14' not allowed with 'C/ObjC'
Removing the flag from PLATFORM_CFLAGS and adding to PLATFORM_CXXFLAGS fixes the issue.
Will offer pull request shortly.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect config.default.android.mk and compare how PLATFORM_CFLAGS and PLATFORM_CXXFLAGS are used. Reproduce the reported compile error for C files, then verify that C compilation no longer receives the C++14 flag while C++ compilation still does.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, cpp
- Domain
- build-system, mobile-dev
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100