openframeworks / openframeworks/openFrameworks
bShouldClose in ofMainLoop stays "true" after calling ofGetMainLoop()->shouldClose();
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
This prevents the loop to be started again when using ofBaseApp inside a thread, after calling ofGetMainLoop()->shouldClose(); to stop the loop and close the app.
I added this line to ofMainLoop::run(shared_ptr window, shared_ptr app)
bShouldClose = false;
I just started using OF, so I am not sure this can be a definitive solution.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at ofMainLoop::run(shared_ptr window, shared_ptr app) and trace how bShouldClose changes when ofGetMainLoop()->shouldClose() is called. Reproduce stopping and restarting an ofBaseApp loop from a thread, then verify that the loop can start again without breaking normal shutdown behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100