openframeworks / openframeworks/openFrameworks

Tiny fix : SolutionDir not ProjectDir

Open
#5,016 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
10.4k
Forks
2.6k
Avg merge
1d 21h
Merged PRs (30d)
9

Description

The lines in

https://github.com/openframeworks/openFrameworks/blob/master/libs/openFrameworksCompiled/proje
ct/vs/openFrameworksDebug.props#L24
https://github.com/openframeworks/openFrameworks/blob/master/libs/openFrameworksCompiled/project/vs/openFrameworksDebug.props#L41
https://github.com/openframeworks/openFrameworks/blob/master/libs/openFrameworksCompiled/project/vs/openFrameworksRelease.props#L23
https://github.com/openframeworks/openFrameworks/blob/master/libs/openFrameworksCompiled/project/vs/openFrameworksRelease.props#L39

should be

<Command>robocopy "$(OF_ROOT)/export/vs/$(Platform_Actual)/" "$(SolutionDir)bin/" "*.dll" /njs /njh /np /fp /bytes
if errorlevel 1 exit 0 else exit %errorlevel%</Command>

not

<Command>robocopy "$(OF_ROOT)/export/vs/$(Platform_Actual)/" "$(ProjectDir)bin/" "*.dll" /njs /njh /np /fp /bytes
if errorlevel 1 exit 0 else exit %errorlevel%</Command>

or just $(TargetDir)

Mostly this doesn't matter
but it can matter if you're building DLL's from openFrameworks code (which are generally output to the solution dir, not the project dir)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the four referenced files: libs/openFrameworksCompiled/project/vs/openFrameworksDebug.props and openFrameworksRelease.props, at the linked command lines. Compare the robocopy destination variables with the issue description, update the affected commands consistently, and verify that DLLs built from openFrameworks code are copied to the solution's bin directory.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.